Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @damondouglas for label java.
R: @damondouglas for label io.

Available commands:

• stop reviewer notifications - opt out of the automated review tooling
• remind me after tests pass - tag the comment author after tests pass
• waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Reminder, please take a look at this pr: @damondouglas @damondouglas

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @chamikaramj for label java.
R: @damondouglas for label io.

Available commands:

• stop reviewer notifications - opt out of the automated review tooling
• remind me after tests pass - tag the comment author after tests pass
• waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

Hello @robertwb would it be possible to merge this one?

Reminder, please take a look at this pr: @chamikaramj @damondouglas

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @robertwb for label java.
R: @damondouglas for label io.

Available commands:

• stop reviewer notifications - opt out of the automated review tooling
• remind me after tests pass - tag the comment author after tests pass
• waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

Reminder, please take a look at this pr: @robertwb @damondouglas

Rebased on master.

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @chamikaramj for label java.
R: @damondouglas for label io.

Available commands:

• stop reviewer notifications - opt out of the automated review tooling
• remind me after tests pass - tag the comment author after tests pass
• waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

Thanks for the fix. Would it be possible to add a test case?

Thanks for the fix. Would it be possible to add a test case?

Thanks!

That's not easy at all: this is linked to system table schema in Snowflake, so requires an integration test. Thing is, IT require a working GCP-run Snowflake, which I don't have access to.

Unfortunately, there is no real way to have tests running against, say, a docker-embedded Snowflake db.

@Abacn is it a blocker?

I don't believe I can execute the IT. I may write a UT to check the query is the one expected, but it's not of great value I think.